Skip to content

[cxx-interop] Emit LValue type in a base subscript assignment expression #60530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

egorzhdan
Copy link
Contributor

This fixes an assertion that tripped when running member-inline.swift test with an unrelated patch:

type is not an l-value in LHS of assignment: Int32
...
3.	While walking into body of setter for subscript(_:) (in module 'MemberInline')

This fixes an assertion that tripped when running `member-inline.swift` test with an unrelated patch:
```
type is not an l-value in LHS of assignment: Int32
...
3.	While walking into body of setter for subscript(_:) (in module 'MemberInline')
```
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Aug 12, 2022
@egorzhdan egorzhdan requested a review from zoecarver August 12, 2022 15:27
@egorzhdan
Copy link
Contributor Author

This is blocking #60332.

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan egorzhdan merged commit c0e652b into main Aug 12, 2022
@egorzhdan egorzhdan deleted the egorzhdan/base-subscript-lvalue branch August 12, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant