Skip to content

[Interop][SwiftToCxx] Update current enum implementation for new enum design #60564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

WANGJIEKE
Copy link
Contributor

Implement the new enum design described in #60524.

All existing features are updated for the new design. The class constructor and operator () in case structs will be implemented in future.

@hyp Could you please review this PR? Thanks.

@hyp hyp added the c++ interop Feature: Interoperability with C++ label Aug 15, 2022
@hyp
Copy link
Contributor

hyp commented Aug 15, 2022

@swift-ci please test

@hyp
Copy link
Contributor

hyp commented Aug 16, 2022

@swift-ci please test

Copy link
Contributor

@hyp hyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hyp
Copy link
Contributor

hyp commented Aug 17, 2022

@swift-ci please test source compatibility and merge

@hyp
Copy link
Contributor

hyp commented Aug 17, 2022

@swift-ci please test source compatibility

@hyp hyp merged commit f5787c9 into swiftlang:main Aug 17, 2022
@WANGJIEKE WANGJIEKE deleted the cxx-interop-new-enum-design branch August 18, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants