[SourceKit] Re-enable cancellation of non-completion requests #60573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the ability to cancel requests, which aren’t code completion requests, again. Previous crashes in SILGen are prevented by disabling cancellation during the SIL stages. Instead, we add dedicated cancellation checkpoints before and after SIL. rdar://98390926
|
@swift-ci Please test |
bnbarham
reviewed
Aug 16, 2022
| // RUN: not %sourcekitd-test -req=diags %s -print-raw-response -id=diag -async -- %s == -cancel=diag 2>&1 | %FileCheck %s | ||
|
|
||
| func foo(x: Invalid1, y: Invalid2) { | ||
| x / y / x / y / x / y / x / y |
There was a problem hiding this comment.
Not the biggest fan of these tests (same with the CursorInfoTest cases). It's okay for this PR, but IMO we should add a wait either somewhere in type checking or just in ASTBuildOperation that continues once it's set. That would allow something like:
// RUN: not %sourcekitd-test -req=diags %s -print-raw-response -id=diag -async -wait -- %s == -cancel=diag == -continue
Could even have different sections we wait at, eg. before type checking, during, after, etc.
bnbarham
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the ability to cancel requests, which aren’t code completion requests, again.
Previous crashes in SILGen are prevented by disabling cancellation during the SIL stages. Instead, we add dedicated cancellation checkpoints before and after SIL.
rdar://98390926