SIL: Don't eagerly erase instructions in builder peepholes. #60604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
jckarter
force-pushed
the
silbuilder-dont-delete-operands-in-peepholes
branch
from
c46bd10 to
ab1aa80
Compare
|
@swift-ci Please test |
Even if the operand doesn't currently have any uses after the peephole, the caller may intend to use the operand for other purposes. If the operand is really unused in the end, then dead code elimination ought to clean it up. Fixes rdar://98418860.
jckarter
force-pushed
the
silbuilder-dont-delete-operands-in-peepholes
branch
from
ab1aa80 to
d3f482a
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if the operand doesn't currently have any uses after the peephole, the
caller may intend to use the operand for other purposes. If the operand is
really unused in the end, then dead code elimination ought to clean it up.
Fixes rdar://98418860.