Skip to content

[Serialization] Suggest a solution path for modified swiftmodules causing deserialization failures #60610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Aug 17, 2022

A large portion of deserialization failures at this points are caused by roots installed over the SDK. Let's extend the error message with a solution for such a case.

rdar://86280699

@xymus xymus requested a review from bnbarham August 17, 2022 21:51
@xymus
Copy link
Contributor Author

xymus commented Aug 17, 2022

@swift-ci Please smoke test

@xymus xymus force-pushed the serial-root-message branch from 9e207e5 to b16bc47 Compare August 17, 2022 23:48
@xymus
Copy link
Contributor Author

xymus commented Aug 17, 2022

@swift-ci Please smoke test

@xymus xymus changed the title [Serialization] Suggest a path to a solution for roots issues in deserialization failures [Serialization] Suggest a solution path for modified swiftmodules causing deserialization failures Aug 18, 2022
… failures

Many deserialization failures at this points are caused by archives
installed over the SDK. Let's extend the current error message with a
solution for such a case.

rdar://86280699
@xymus xymus force-pushed the serial-root-message branch from b16bc47 to 9c840a7 Compare August 18, 2022 19:31
@xymus
Copy link
Contributor Author

xymus commented Aug 18, 2022

Removed the use of the root jargon.

@swift-ci Please smoke test

@xymus xymus merged commit e17590e into swiftlang:main Aug 18, 2022
@xymus xymus deleted the serial-root-message branch August 18, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants