More generics gardening #6063
Merged
More generics gardening #6063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
Another oddly-named utility function with poorly-defined behavior. It returned true for archetypes, generic parameters, existential types, and metatypes of existential types. However, it would return false for dependent member types, or metatypes of archetypes, and so on. All the callers were doing something bad to begin with, so changing them over to more precise predicates improved the code. In particular, this simplifies substitution construction in the SIL parser, and makes it stricter, which turned up a couple of mistakes in the SIL tests where we were doing stuff with non-conforming types.
This is made redundant by TypeBase::isAny().
slavapestov
force-pushed
the
more-generics-gardening
branch
from
553f320 to
aaaded5
Compare
|
@swift-ci Please smoke test macOS |
1 similar comment
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.