[Diagnostics] Improve diagnostics for invalid type access on existential types. #60671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typealias access on existential types by mentioning the base type in the error message.
existential type in expression context.
|
@swift-ci please smoke test |
theblixguy
reviewed
Aug 22, 2022
| @@ -188,6 +187,25 @@ Type TypeResolution::resolveDependentMemberType( | |||
|
|
|||
| auto *concrete = ref->getBoundDecl(); | |||
|
|
|||
| if (auto concreteBase = genericSig->getConcreteType(baseTy)) { | |||
| bool hasUnboundOpener = !!getUnboundTypeOpener(); | |||
There was a problem hiding this comment.
Nope, I want the value of getUnboundTypeOpener as a bool. This !! pattern is used elsewhere in TypeCheckType.cpp on getUnboundTypeOpener to do the same thing.
There was a problem hiding this comment.
Oh interesting! I didn’t know we had a !!.
There was a problem hiding this comment.
I didn't either until I looked at the other call-sites of TypeChecker::isUnsupportedMemberTypeAccess 😄
There was a problem hiding this comment.
I didn’t know we had a
!!
Some time ago this pattern made me hang for a second too. It's just a double negation and equivalent to (bool)getUnboundTypeOpener() in this context.
slavapestov
approved these changes
Aug 22, 2022
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the error message for invalid associated type and type alias access on a protocol or existential type, and fixes a case of missing diagnostics for invalid type access on a generic parameter that is same-type-constrained to an existential type.
Resolves: rdar://88092865