Skip to content

[Localization] Switch diagnostics/localization to .strings format #60707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2022

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Aug 22, 2022

.strings format is just a pair of a id and a corresponding message so it's easier to work with for
both translators and tools.

The format is as follows:

  • Comment: /* ... */
  • Diagnostic: "<diagnostic-id>" = "<diagnostic-message>";

YAML producer and conversion tool are removed in the last commit as a unit to make it easier
to re-instate them in the future if need arises.

@xedin xedin requested a review from hborla August 22, 2022 17:58
@xedin
Copy link
Contributor Author

xedin commented Aug 22, 2022

@swift-ci please clean test

@xedin
Copy link
Contributor Author

xedin commented Aug 22, 2022

Please test with following pull request:
swiftlang/llvm-project#5172

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Aug 22, 2022

Please test with following pull request:
swiftlang/llvm-project#5172

@swift-ci please test macOS platform

@xedin xedin merged commit bca9004 into swiftlang:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants