[pruned-liveness] Teach PrunedLiveBlocks how to handle liveness for multiple bits. #60710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltiple bits of liveness rather than just one. This is useful for making a form of PrunedLiveness that is sensitive to address fields. I wired up the current PrunedLiveness to just use PrunedLiveBlocks with num bits set to 1.
|
@swift-ci test |
…resent its state instead of 1 + missing value in DenseMap. The reason why I am doing this is that in order to be able to use PrunedLivenessBlocks with multiple elements, we can no longer rely on dead being represented by a block not having any state, since a dead bit could have a neighboring live bit. That being said, the only place that this is used now is the current PrunedLiveness implementation which only stores a single bit... but that still at least exercises the code and lets us know that it works.
gottesmm
force-pushed
the
pr-1212688e62da727448883168d77ba9b98fa6d4dc
branch
from
d451aca to
e51e17f
Compare
|
@swift-ci test |
atrick
approved these changes
Aug 22, 2022
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for landing a larger FieldSensitivePrunedLiveness (I am chopping off a larger part of that work).
Importantly, by committing this separately, I can use the current PrunedLiveness implementation to validate this larger piece of work.