[Dependency Scan] Remove redundant recombination of arguments in 'initCompilerInstanceForScan' into a string, before being re-parsed. #60712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Aug 22, 2022
…vocation command Since we are passing in the command-line to the scanner library with individual flags and paths as separate strings, this should not be necessary. Depends on swiftlang/swift#60712 Part of rdar://98985453
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Aug 22, 2022
…vocation command Since we are passing in the command-line to the scanner library with individual flags and paths as separate strings, this should not be necessary. Depends on swiftlang/swift#60712 Part of rdar://98985453
artemcm
force-pushed
the
RemoveRedundantScanCommandCombo
branch
from
157ea0a to
90c66b8
Compare
|
@swift-ci smoke test |
…tCompilerInstanceForScan' into a string, before being re-parsed. This does not seem to serve a purpose other than corrupting arguments with whitespaces - they get merged into one large string where the whitespace boundary between arguments and whitespaces within arguments are blurred. Part of rdar://98985453
artemcm
force-pushed
the
RemoveRedundantScanCommandCombo
branch
from
90c66b8 to
baec315
Compare
|
@swift-ci smoke test |
nkcsgexi
approved these changes
Aug 22, 2022
artemcm
added a commit
to artemcm/swift-driver
that referenced
this pull request
Aug 23, 2022
…vocation command Since we are passing in the command-line to the scanner library with individual flags and paths as separate strings, this should not be necessary. Depends on swiftlang/swift#60712 Part of rdar://98985453
|
swiftlang/swift-driver#1159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not seem to serve a purpose other than corrupting arguments with whitespaces - they get merged into one large string where the whitespace boundary between arguments and whitespaces within arguments are blurred.
Part of rdar://98985453