Skip to content

[CodeComplete] Show global completions from modules that are imported as @_spi #60721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 23, 2022

If a module is imported as @_spi, we didn’t receive any global completions from it.

rdar://99027179

@ahoppen ahoppen requested a review from rintaro August 23, 2022 12:24
@ahoppen ahoppen force-pushed the pr/global-results-from-spi-module branch from 6187c9e to 415e7ca Compare August 24, 2022 11:09
… as `@_spi`

If a module is imported as `@_spi`, we didn’t receive any global completions from it.

rdar://99027179
@ahoppen ahoppen force-pushed the pr/global-results-from-spi-module branch from 415e7ca to bd2771e Compare August 24, 2022 21:52
@ahoppen
Copy link
Member Author

ahoppen commented Aug 24, 2022

@swift-ci Please test

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It's a little unfortunate that -spi caches have duplicated non--spi decls, but I guess it's not trivial to separate them. We can revisit this later.

@ahoppen ahoppen merged commit a643acd into swiftlang:main Aug 25, 2022
@ahoppen ahoppen deleted the pr/global-results-from-spi-module branch August 25, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants