Skip to content

[test] IRGen/opaque_result_alwaysInlineIntoClient: disable on non-local test configs #60735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

[test] IRGen/opaque_result_alwaysInlineIntoClient: disable on non-local test configs #60735

merged 1 commit into from
Aug 23, 2022

Conversation

lorentey
Copy link
Member

This silences a CI blocker issue.

rdar://97995151

@lorentey lorentey requested a review from xedin August 23, 2022 21:07
@lorentey
Copy link
Member Author

@swift-ci smoke test and merge

@lorentey
Copy link
Member Author

Hm, a better fix for this class of problems would probably be to disable the swift_interpreter feature when remote_run or device_run is configured in lit.cfg.

@lorentey lorentey requested a review from shahmishal August 23, 2022 23:08
@lorentey
Copy link
Member Author

@swift-ci smoke test

@xedin
Copy link
Contributor

xedin commented Aug 23, 2022

Interesting! Thank you, @lorentey!

@swift-ci swift-ci merged commit 5d30b59 into swiftlang:main Aug 23, 2022
@lorentey lorentey deleted the wrangling branch August 24, 2022 01:19
@lorentey lorentey mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lorentey @xedin @swift-ci