Skip to content

[SIL] Fix tuple keypath verifier #60737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

[SIL] Fix tuple keypath verifier #60737

merged 1 commit into from
Aug 26, 2022

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Aug 24, 2022

Don't compare a lowered type to an unlowered type because we run into the situation where a @thick Any.Type != Any.Type causing something like the following to crash:

typealias Hello = (a: Int, b: Any.Type)

let x = \Hello.b

@Azoy Azoy requested a review from jckarter August 24, 2022 01:10
@Azoy
Copy link
Contributor Author

Azoy commented Aug 24, 2022

@swift-ci please smoke test

@Azoy
Copy link
Contributor Author

Azoy commented Aug 24, 2022

@swift-ci please smoke test Windows

1 similar comment
@Azoy
Copy link
Contributor Author

Azoy commented Aug 24, 2022

@swift-ci please smoke test Windows

@Azoy Azoy merged commit 315ee2a into swiftlang:main Aug 26, 2022
@Azoy Azoy deleted the fix-tuple-kp branch August 26, 2022 22:29
meg-gupta pushed a commit to meg-gupta/swift that referenced this pull request Aug 27, 2022
@Azoy @meg-gupta
Fix tuple keypath verifier (swiftlang#60737)
53b0976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Azoy