Ban address phis in non-OSSA SIL #60763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci test |
meg-gupta
changed the title
meg-gupta
force-pushed
the
looprotateaddressphi
branch
from
b0566ba to
fb4837f
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
meg-gupta
force-pushed
the
looprotateaddressphi
branch
from
fb4837f to
bbb81dd
Compare
…nt just to avoid the address phi absence assert
meg-gupta
force-pushed
the
looprotateaddressphi
branch
from
bbb81dd to
17285c0
Compare
|
@swift-ci test |
|
@swift-ci source compatibility test |
meg-gupta
changed the title
|
@swift-ci test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LoopRotate and ArrayPropertyOpt were the remaining optimizations generating address phis. This PR changes them to avoid generating address phis and turns on verification to make sure we don't have address phis in SIL