[SourceKit] Workaround a bug that parameterized protocols without 'any' cannot be mangled #60765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
CodaFi
requested changes
Aug 26, 2022
ahoppen
force-pushed
the
pr/rdar98623438
branch
from
a673691 to
79b3459
Compare
ahoppen
changed the title
ahoppen
force-pushed
the
pr/rdar98623438
branch
from
79b3459 to
d58df38
Compare
|
OK, I’ve decided to use this PR to implement a minimal workaround to avoid the crash on the SourceKit side so the underlying issue can be fixed independently. |
ahoppen
force-pushed
the
pr/rdar98623438
branch
from
d58df38 to
0aa15a8
Compare
ahoppen
changed the title
ahoppen
force-pushed
the
pr/rdar98623438
branch
from
0aa15a8 to
03484b8
Compare
|
@swift-ci Please smoke test |
CodaFi
reviewed
Aug 26, 2022
| // declarations. rdar://99176683 | ||
| // To avoid crashing in USR generation, return an error for now. | ||
| if (auto Ty = DInfo.VD->getInterfaceType()) { | ||
| if (auto MetaTy = Ty->getAs<MetatypeType>()) { |
There was a problem hiding this comment.
You'll want to look through all layers of metatype you can get.
…y' cannot be mangled `typealias` is currently allowed to refer to a protocol without the `any` keyword. This breaks mangling the typealias type into a USR will crash because parameterized protocols are expected to be `any` types. Implement a SourceKit-specific minimal workaround for that problem by not computing USRs for parameterized protocols. rdar://98623438
ahoppen
force-pushed
the
pr/rdar98623438
branch
from
03484b8 to
c8a7e55
Compare
CodaFi
approved these changes
Aug 26, 2022
|
@swift-ci Please smoke test |
rintaro
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typealiasis currently allowed to refer to a protocol without theanykeyword. This breaks mangling the typealias type into a USR will crash because parameterized protocols are expected to beanytypes.Implement a SourceKit-specific minimal workaround for that problem by not computing USRs for parameterized protocols.
rdar://98623438