[ConstraintSystem] Adjust contextual locators to support updated Double/CGFloat conversion #60784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re coercion Contextual conversion constraint is placed on `result of closure body` and solution application logic should match that.
…rsions related to contextual type Previously locator for value-to-value conversion would just drop all the contextual information if the conversion occurred while converting expression to a contextual type. This is incorrect for i.e. `return` statements and other targets because because they are solved separately and using the same locator would result in a clash when solutions are merged.
|
Note for posterity - I think we can remove |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
hborla
approved these changes
Aug 25, 2022
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contextual conversion constraint is placed on
result of closure bodyand solution application logic should match that.
Previously locator for value-to-value conversion would just drop
all the contextual information if the conversion occurred while
converting expression to a contextual type. This is incorrect for
i.e.
returnstatements and other targets because because theyare solved separately and using the same locator would result in
a clash when solutions are merged.
Resolves: rdar://99059525