[interop][SwiftToCxx] experimentally expose Swift::String type to C++ #60785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only member that's currently exposed is the default initializer, everything else is in extensions
hyp
force-pushed
the
eng/string-to-nsstring
branch
from
88d45dc to
06d9fd2
Compare
|
Also need to not expose unexposed members to avoid |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only stdlib member that's currently exposed is the default initializer, everything else is in extensions.
However, we also add a new generated
operator NSString *for casting a SwiftStringvalue toNSString *on the C++ side.