[cxx-interop] Mark un-specialized class templates as unavailable in Swift. #60786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft because I haven't fixed the tests yet. |
zoecarver
force-pushed
the
unavailable-attr-class-templates
branch
from
ab84b15 to
f049d52
Compare
|
@swift-ci please test |
|
@hyp @egorzhdan this is ready for review now. |
zoecarver
changed the title
egorzhdan
approved these changes
Sep 28, 2022
…wift. They don't really work, so let's not "support" them yet.
zoecarver
force-pushed
the
unavailable-attr-class-templates
branch
from
f049d52 to
dbf4864
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
zoecarver
commented
Oct 21, 2022
| @@ -1,9 +1,9 @@ | |||
| // RUN: %empty-directory(%t) | |||
There was a problem hiding this comment.
@hyp I'll let you decide if you want to land this PR before fixing this test and the next one. Sorry I did such a terrible job "fixing" these. I couldn't always understand the error, so maybe we can work on them offline.
|
@swift-ci please test |
This reverts commit ac64f91.
|
@swift-ci please test |
hyp
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They don't really work, so let's not "support" them yet.