[CopyProp] Don't extend lifetime over end_access. #60792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-chandler
force-pushed
the
canonicalize_ossa_lifetime/access_scope_ends
branch
10 times, most recently
from
c559402 to
70323ff
Compare
If there is a consuming use of the value inside an access scope, the lifetime should not be extended over the end_access instruction.
nate-chandler
force-pushed
the
canonicalize_ossa_lifetime/access_scope_ends
branch
from
70323ff to
477461b
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please benchmark |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a consuming use of the value inside an access scope, the lifetime should not be extended over the end_access instruction.