[BuilderTransform] Lift all restrictions from variable decls when AST… #60839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll incorporate test into existing result builder test file once the AST transform is enabled by default. |
|
@swift-ci please build toolchain |
xedin
force-pushed
the
lift-var-restrictions-in-result-builder-ast-transform
branch
from
cb0825b to
ce1ffd7
Compare
|
@swift-ci please smoke test |
hborla
approved these changes
Aug 30, 2022
|
@swift-ci please build toolchain macOS platform |
1 similar comment
|
@swift-ci please build toolchain macOS platform |
xedin
force-pushed
the
lift-var-restrictions-in-result-builder-ast-transform
branch
from
2b20de3 to
f4bee50
Compare
|
@swift-ci please build toolchain macOS platform |
xedin
force-pushed
the
lift-var-restrictions-in-result-builder-ast-transform
branch
from
f4bee50 to
b1c27cb
Compare
… transform is enabled Result builders would be able to declare: - uninitialized variables - variables with property wrappers (with and without explicit initializer) - default initializable variables i.e. `var x: Int?` - computed variables - `lazy` variables
xedin
force-pushed
the
lift-var-restrictions-in-result-builder-ast-transform
branch
2 times, most recently
from
8c45dd8 to
480bcca
Compare
xedin
added
the
swift evolution approved
|
SE-0373 has been approved, I'm going to land this PR. |
|
@swift-ci please test |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… transform is enabled
Result builders would be able to declare:
var x: Int?lazyvariables