[interop][SwiftToCxx] initial generic struct support #60848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
might need a bit of cleanup first. |
|
@swift-ci please test linux platform |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Added support for passing/returning concrete-type bounded generics |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
egorzhdan
reviewed
Aug 31, 2022
| printGenericTypeParamTypeName(genericParamType); | ||
| }); | ||
| os << ">\n"; | ||
| os << "requires "; |
There was a problem hiding this comment.
Sorry if I missed this: does the generated header always require C++20?
There was a problem hiding this comment.
At the moment yes, this will be relaxed in the future.
…pecialized generic though)
…pe metadata accessor function for generic types
… to concrete generic params
…ncrete type params
hyp
force-pushed
the
eng/generic-type-1
branch
from
6df0996 to
907b3a9
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial patch only adds support for passing and returning direct generic values , without supporting concrete instantiations, or using them in generic context, or even methods on them. More to come.