[code-completion] Fix crash in printParameterList when paramListTy is… #6085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Error type rdar://problem/28867801
|
@swift-ci please smoke test |
jrose-apple
reviewed
Dec 6, 2016
| @@ -2461,7 +2461,7 @@ void PrintAST::printParameterList(ParameterList *PL, Type paramListTy, | |||
| bool isCurried, | |||
| std::function<bool()> isAPINameByDefault) { | |||
| SmallVector<ParameterTypeFlags, 4> paramFlags; | |||
| if (paramListTy) { | |||
| if (paramListTy && !paramListTy.getPointer()->hasError()) { | |||
There was a problem hiding this comment.
Type has an overloaded operator->, so you can just use paramListTy->hasError().
There was a problem hiding this comment.
Thanks, I'll fix it up!
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash exposed by validation-test/IDE/crashers/101-swift-decl-print.swift. When paramListTy was Error type, it was still treated as a valid parameter list type. This resulted in a path through the method where the paramFlags vector had fewer elements than the parameter list, PL, so paramFlags[i], where i is an index into PL, triggered an assert.
Resolves rdar://problem/28867801.
… Error type rdar://problem/28867801