[Freestanding] Only run tasks when they are awaited up on in task-to-thread model #60860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
ktoso
reviewed
Aug 31, 2022
ktoso
reviewed
Aug 31, 2022
ktoso
reviewed
Aug 31, 2022
ktoso
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
Looks okey AFAICS, though the naming of this mode is very weird sounding, any better ideas? The "task to thread" doesn't really mean anything when one reads it hm. "to" what, it is not that a task is mapped "to" a thread after all, so it sounds even misleading somewhat. Is it perhaps "run tasks inline" mode, that's what it does after all 🤔
ktoso
reviewed
Aug 31, 2022
| // our state | ||
| _swift_task_setCurrent(oldTask); | ||
| queueHead = fragment->waitQueue.load(std::memory_order_acquire); | ||
| continue; |
async-let task, we run it in the context of the parent task.
rokhinip
force-pushed
the
rokhinip/92347604-run-task-upon-await
branch
from
18e8919 to
a606892
Compare
|
@swift-ci please test |
|
preset=stdlib_S_standalone_minimal_macho_x86_64,build,test |
mikeash
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the task-to-thread model, there are no threading mechanisms by which work could be offloaded onto another thread. When creating structured concurrency tasks however, we know that they will be awaited upon by the calling parent task which can therefore execute the child task at the point of await.
Rdar: rdar://92347604