Skip to content

[pruned-liveness] Implement FieldSensitiveAddressPrunedLiveness. #60867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gottesmm
Copy link
Contributor

This is the same algorithm as pruned liveness but assumes that one is tracking
liveness from an address and uses the same scheme as DI to track liveness as a
bit vector.

This is the same algorithm as pruned liveness but assumes that one is tracking
liveness from an address and uses the same scheme as DI to track liveness as a
bit vector.
@gottesmm gottesmm requested a review from atrick August 31, 2022 00:26
@gottesmm
Copy link
Contributor Author

Not used anywhere, just slicing the larger patch down.

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci test windows platform

@gottesmm
Copy link
Contributor Author

Windows failure is due to a CAS issue being fixed here: swiftlang/llvm-project#5236

@gottesmm
Copy link
Contributor Author

@swift-ci test windows platform

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we'll want to split the pruned field liveness into a separate analysis and optimize the scalar liveness to avoid the block-keyed DenseMap completely.

The element numbering code should become its own standard SIL utility.

@gottesmm gottesmm merged commit 15e17b2 into swiftlang:main Aug 31, 2022
@gottesmm gottesmm deleted the pr-e5ec659a62bef9590245df9b47f851d787746754 branch August 31, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants