[move-only] Initial patch for move only address checking. #60889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
eeckstein
previously requested changes
Sep 1, 2022
gottesmm
dismissed
eeckstein’s stale review
Fixed the problem in a different PR that was approved by Erik.
… to handle mark_must_check on addresses.
…cker. Some notes: 1. I added support for both loadable/address only types. 2. These tests are based off of porting the move only object tests for inout, vars, mutating self, etc. 3. I did not include already written tests for address only types in this specific merge since I need to change us to borrow move only var like types. Without that, we get a lot of spurious error msgs and the burden of writing that is not worth it. So instead in a forthcoming commit where I fix that issue in SILGen, I will commit the corresponding address only tests for this work. 4. I did not include support for trivial types in this. I am going to do object/address for that at the same time.
gottesmm
force-pushed
the
initial-move-only-address-checker
branch
from
ae4dd88 to
0a16cc3
Compare
|
@swift-ci test |
|
One thing to keep in mind with this patch series is that I left out the address only tests that I have on a branch. This was done on purpose since until I fix SILGen to make it so that we borrow move only var like things when we pass them to function arguments, we hit a ton of spurious errors on the tests. I am going to upload those tests together with the borrow fix just to save my hands a ton of unnecessary typing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I handle now var, inout, mutating self that are non-trivial/loadable. Also, I handle inits correctly. Still a work in progress, but enough is done to get something into tree.