Skip to content

[cxx-interop] Fix foreign reference types with reference counting that live in a namespace. #60907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

zoecarver
Copy link
Contributor

Before this patch we tried to do lookup in the _ObjC module for the retain/release functions. Now we use the clang module that the reference type lives in.

…t live in a namespace.

Before this patch we tried to do lookup in the _ObjC module for the retain/release functions. Now we use the clang module that the reference type lives in.
@zoecarver zoecarver added the c++ interop Feature: Interoperability with C++ label Sep 1, 2022
@zoecarver zoecarver requested review from hyp and egorzhdan September 1, 2022 17:50
@zoecarver
Copy link
Contributor Author

@swift-ci please test

@zoecarver zoecarver marked this pull request as ready for review September 1, 2022 17:50
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zoecarver zoecarver merged commit 73ace80 into swiftlang:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants