sema: diagnose @_spi_available on all platforms #60983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
tshortli
reviewed
Sep 7, 2022
@_spi_available should only be used when the symbol is publically available in some deployment platforms, otherwise we should use @_spi.
nkcsgexi
force-pushed
the
warn-all-spi-available
branch
from
a24c2ae to
4f9cfd3
Compare
|
@swift-ci please smoke test |
|
I think this diagnostic overall makes sense, and perhaps this is an edge case, but a missing availability annotation for a specific platform is expected in some circumstances, like for the standard library or any other library that is available at the start of a platform. Therefore enumerating all explicit annotations doesn't really answer the question of whether a declarations is SPI available on all platforms relevant to the module, since declarations are implicitly always available on platforms without annotations. So this diagnostic may be misleading in a small set of scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@_spi_available should only be used when the symbol is publically available in some deployment platforms, otherwise, we should use @_spi.