[C++-Interop] Import const &T function parameters as @in_guaranteed
#61000
Conversation
|
@swift-ci please smoke test |
|
Not for this PR necessarily, but we are still missing the one in the allocator/initializer case 😞 |
plotfi
force-pushed
the
const-ref-in_guaranteed
branch
2 times, most recently
from
8d8fac8 to
8bbf8f9
Compare
Added |
| @@ -36,42 +36,34 @@ func testFunction() { | |||
|
|
|||
| // RUN: %target-swift-frontend -c -enable-experimental-cxx-interop -enable-objc-interop -I %S/Inputs %s -emit-silgen -o - | %FileCheck %s | |||
|
|
|||
| // COM: FIXME: should it be @in_guaranteed OptionsStruct? https://github.com/apple/swift/issues/60601 | |||
| // CHECK: [[FN1:%[0-9]+]] = function_ref @$sSo19OptionsConsumerObjCC7optionsABSo0A6StructV_tcfC : $@convention(method) (OptionsStruct, @thick OptionsConsumerObjC.Type) -> @owned OptionsConsumerObjC | |||
There was a problem hiding this comment.
This one is the one that I was confused. IIUC $sSo19OptionsConsumerObjCC7optionsABSo0A6StructV_tcfC demangles to __C.OptionsConsumerObjC.__allocating_init(options: __C.OptionsStruct) -> __C.OptionsConsumerObjC which seems to be an Obj-C initializer, and it does not have @in nor @in_guaranteed. I don't know if this is required, or in this case it is fine to pass a copy.
But this one is different than in your new test, which shows a non-mangled name. I wonder if the designated initializer bit changes something.
plotfi
force-pushed
the
const-ref-in_guaranteed
branch
from
8bbf8f9 to
25aa850
Compare
|
@swift-ci please smoke test |
plotfi
force-pushed
the
const-ref-in_guaranteed
branch
from
25aa850 to
834fe9a
Compare
|
@swift-ci please smoke test |
|
@hyp Do these changes look ok to you? |
test/Interop/Cxx/reference/Inputs/reference-silgen-cxx-objc-ctors+init.h
Outdated
Show resolved
Hide resolved
test/Interop/Cxx/reference/Inputs/reference-silgen-cxx-objc-ctors+init.h
Outdated
Show resolved
Hide resolved
When passing value types as a const-ref to a C++ API, ensure that the caller is tasked with handling the lifetime of the instance passed in.
plotfi
force-pushed
the
const-ref-in_guaranteed
branch
from
834fe9a to
84a69c4
Compare
|
Addressed your comments @zoecarver |
|
@swift-ci please smoke test |
When passing value types as a const-ref to a C++ API, ensure that the caller is tasked with handling the lifetime of the instance passed in.
@hyp @zoecarver @drodriguez