Skip to content

Add link between swiftBasic and swiftAST #61001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

Add link between swiftBasic and swiftAST #61001

merged 1 commit into from
Sep 9, 2022

Conversation

etcwilde
Copy link
Member

@etcwilde etcwilde commented Sep 8, 2022

swiftBasic uses InFlightDiagnostic::flush, which is defined in swiftAST. The build graph did not contain that link edge, so it failed to link on Windows. No idea how it's working on macOS ¯_(ツ)_/¯.

@etcwilde
Add link between swiftBasic and swiftAST
9010813 
swiftBasic uses `InFlightDiagnostic::flush`, which is defined in
swiftAST. The build graph did not contain that link edge, so it failed
to link on Windows. No idea how it's working on macOS.
@etcwilde etcwilde requested review from compnerd and edymtt September 8, 2022 17:09
@etcwilde
Copy link
Member Author

etcwilde commented Sep 8, 2022

@swift-ci please test windows

@etcwilde
Copy link
Member Author

etcwilde commented Sep 8, 2022

@swift-ci please test macOS

compnerd
compnerd approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤮 if it builds, it ships?

@etcwilde
Copy link
Member Author

etcwilde commented Sep 8, 2022

@swift-ci please test linux

@etcwilde etcwilde mentioned this pull request Sep 8, 2022
Merged
@etcwilde
Copy link
Member Author

etcwilde commented Sep 8, 2022 •
edited
Loading

🤮 if it builds, it ships?

I certainly feel nauseous about this patch too. 🤢
Eventually, we should probably push the diagnostic pieces up into swiftBasic and break the cycle.

@etcwilde
Copy link
Member Author

etcwilde commented Sep 8, 2022

macOS failure:

/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/stdlib/public/Cxx/std/String.swift:30:34: error: value of type 'std.string' (aka 'std.__1.__CxxTemplateInstNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEE') has no member '__c_strUnsafe'
    self.init(cString: cxxString.__c_strUnsafe())
                       ~~~~~~~~~ ^~~~~~~~~~~~~

@etcwilde
Copy link
Member Author

etcwilde commented Sep 8, 2022

@swift-ci please smoke test macOS

@CodaFi
Copy link
Contributor

CodaFi commented Sep 8, 2022

I think I can sink the version parsing out of Basic. This is... quite the layering violation.

@tshortli tshortli mentioned this pull request Sep 9, 2022
Merged
@etcwilde etcwilde merged commit 4b7db51 into swiftlang:main Sep 9, 2022
@etcwilde etcwilde mentioned this pull request Sep 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@edymtt edymtt Awaiting requested review from edymtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etcwilde @CodaFi @compnerd