Skip to content

[5.7] Cherry pick two test changes into 5.7 #61038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2022
Merged

[5.7] Cherry pick two test changes into 5.7 #61038

merged 2 commits into from
Sep 11, 2022

Conversation

shahmishal
Copy link
Member

hamishknight and others added 2 commits September 10, 2022 19:02
@hamishknight @shahmishal
[test] Re-enable forward-slash-regex-skipping-allowed.swift
6f31973 
Adjust to account for output differences between
asserts and non-asserts builds.

rdar://95806819
(cherry picked from commit 6c091a5)
@ktoso @shahmishal
Disable test while we fix it; the SIL assertions are too detailed
bad59b8 
(cherry picked from commit ac32323)
@shahmishal shahmishal requested a review from a team as a code owner September 11, 2022 02:03
@shahmishal
Copy link
Member Author

cc: @hamishknight @ktoso

@shahmishal
Copy link
Member Author

@swift-ci test

@ktoso
Copy link
Contributor

ktoso commented Sep 11, 2022

Lgtm :)

@shahmishal shahmishal merged commit 86def8f into release/5.7 Sep 11, 2022
@shahmishal shahmishal deleted the cherry-pick-two-test-changes-5.7 branch September 11, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahmishal @ktoso @hamishknight