Fix bug with lexical recursive property. #61042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When examining non-trivial types which were non-lexical, when a field lacks a field decl (as happens with tuples), whether the type was annotated @_eagerMove was overlooked, resulting in incorrectly determining that a leaf was lexical.
nate-chandler
force-pushed
the
fix-lexical-recursive-properties-bug
branch
from
a2f062b to
02459d0
Compare
In addition to starting all RecursiveProperties values which are NonTrivial as Lexical, also mark instances of the structs which are modified to become NonTrivial to simultaneously become Lexical.
nate-chandler
force-pushed
the
fix-lexical-recursive-properties-bug
branch
from
02459d0 to
af6749e
Compare
|
@swift-ci please test and merge |
|
@swift-ci please test windows platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test windows platform |
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting properties to be non-trivial, also set them to be lexical. And then apply overrides from attributes.