[CSClosure] Fix property wrapper handling #61052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `computeWrappedValueType` is incorrect because that return a type of the wrapped variable and not the *wrapper* variable (one that starts with `_`). Resolves: swiftlang#61017
|
@swift-ci please test |
hborla
approved these changes
Sep 12, 2022
theblixguy
reviewed
Sep 12, 2022
If a variable with attached property wrapper has an initializer expression it could be modified by implicit wrapper application, if there is no initializer - one would be synthesized by the compiler (without arguments). In both cases target has to be pre-checked before constraints are generated for it. Resolves: swiftlang#61024
xedin
force-pushed
the
closure-property-wrapper-fixes
branch
from
0473a80 to
61d3a9f
Compare
|
@swift-ci please test |
Comment on lines
+589
to
+590
| https://github.com/apple/swift/issues/61024 | ||
| do { |
There was a problem hiding this comment.
Took me a while to realize why this link compiles haha (statement label + comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inittargets of wrapped varsIf a variable with attached property wrapper has an initializer
expression it could be modified by implicit wrapper application,
if there is no initializer - one would be synthesized by the
compiler (without arguments). In both cases target has to be
pre-checked before constraints are generated for it.
Using
computeWrappedValueTypeis incorrect becausethat return a type of the wrapped variable and not
the wrapper variable (one that starts with
_).Resolves: #61024
Resolves: #61017