[Sema] Add param indicate diagnose or not in lookupPrecedenceGroupForInfixOperator #61066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LucianoPAlmeida could we instead base the diagnostic on presence of |
LucianoPAlmeida
force-pushed
the
diagnose-operator-crash
branch
from
5d21a9b to
004db7c
Compare
LucianoPAlmeida
force-pushed
the
diagnose-operator-crash
branch
from
004db7c to
2b5054f
Compare
Just adjusted :) |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to emit a fix-it for a diagnostic
exprNeedsParensInsideFollowingOperatorindirectly callslookupPrecedenceGroupForInfixOperatorwhich by default also emits diagnostics which in this case crashes diagnostic engine. So we add the option to calllookupPrecedenceGroupForInfixOperatorwithout any diagnostic in cases are not needed.Resolves: #60954
Resolves: rdar://99562101