Skip to content

Separate out ASCII and UTF8 in NSString accessors, and use the ASCII one where we really need ASCII #61086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 23, 2022
Merged

Separate out ASCII and UTF8 in NSString accessors, and use the ASCII one where we really need ASCII #61086

merged 9 commits into from
Sep 23, 2022

Conversation

Catfish-Man
Copy link
Contributor

No description provided.

@Catfish-Man Catfish-Man self-assigned this Sep 14, 2022
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please benchmark

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man Catfish-Man marked this pull request as ready for review September 14, 2022 22:26
kperryua
kperryua reviewed Sep 14, 2022
View reviewed changes
test/stdlib/NSSlowTaggedLocalizedString.swift Outdated
@@ -14,6 +14,8 @@ import StdlibUnittest

let longTaggedTests = TestSuite("NonContiguousTaggedStrings")
var constant = "Send Message to different Team"
//doesn't fit in a tagged pointer because of ', but does fit in a SmallString
var shortNonTagged = "Don't Save"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the "smart" apostrophe, or just ' (ASCII: 0x27) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like it's U+0027, should we be using something like U+2019 instead so that it's not an ASCII string so that decoding as ASCII will fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh, copy-paste from the bug report has betrayed me! I'll fix that, thanks for catching it

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

1 similar comment
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

ok, the Mac test failure is a bug in the test. I've identified what the problem is, but not a fix yet.

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test macOS platform

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test macOS platform

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please clean test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@Catfish-Man Catfish-Man mentioned this pull request Sep 21, 2022
Merged
@Catfish-Man
Copy link
Contributor Author

@swift-ci please test

@Catfish-Man Catfish-Man merged commit 3292f4e into swiftlang:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmschonfeld jmschonfeld jmschonfeld left review comments

@kperryua kperryua kperryua left review comments

Assignees

@Catfish-Man Catfish-Man

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Catfish-Man @jmschonfeld @kperryua