[CMake] Don't pass -embed-bitcode to module generation commands. #6109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the commands Pete added in 5834df3, doing slightly more work by compiling Swift sources twice in order to start building downstream libraries sooner. Really, we should diagnose when -embed-bitcode is passed here, instead of generating nonsense commands and then falling over. I filed https://bugs.swift.org/browse/SR-3352 for that. rdar://problem/29537164
|
@swift-ci Please test |
|
Build failed |
|
Ah, i missed that. Looks like a very reasonable change so LGTM. |
|
Build failed |
|
@swift-ci Please test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Dec 7, 2016
…ftlang#6109) These are the commands Pete added in 5834df3, doing slightly more work by compiling Swift sources twice in order to start building downstream libraries sooner. Really, we should diagnose when -embed-bitcode is passed here, instead of generating nonsense commands and then falling over. I filed https://bugs.swift.org/browse/SR-3352 for that. rdar://problem/29537164
jrose-apple
added a commit
that referenced
this pull request
Dec 7, 2016
…) (#6113) These are the commands Pete added in 5834df3, doing slightly more work by compiling Swift sources twice in order to start building downstream libraries sooner. Really, we should diagnose when -embed-bitcode is passed here, instead of generating nonsense commands and then falling over. I filed https://bugs.swift.org/browse/SR-3352 for that. rdar://problem/29537164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the commands Pete added in #5472, doing slightly more work by compiling Swift sources twice in order to start building downstream libraries sooner.
Really, we should diagnose when -embed-bitcode is passed here, instead of generating nonsense commands and then falling over. I filed SR-3352 for that.
rdar://problem/29537164