[5.7] [SymbolGraphGen] Refactor export-import logic #61112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please build toolchain macOS |
airspeedswift
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #61049
Description: This PR fixes a handful of bugs in SymbolGraphGen's export-import logic, primarily around Clang modules, deep levels of extensions, and synthesized symbols. This allows symbol graphs for modules which export-import Foundation to successfully be processed by Swift-DocC without crashing.
Risk: Low. The changes are specific to SymbolGraphGen, and only affect modules which use
@_exported importstatements. Regular compilation is unaffected.Review by: @franklinsch
Testing: Two lit tests,
SymbolGraph/ClangImporter/ExportedImport.swiftandSymbolGraph/Module/ThirdOrder, were added to reproduce the issues which occur in Foundation. Existing lit tests all pass.Issue: rdar://99939379