[Sanitizer] Deflake test tsan libdispatch #61165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test does:
```
race()
print("Done!")
// CHECK: ThreadSanitizer: data race
// CHECK: Done!
```
We see some recent cases where the output of the test binary on iOS
devices was:
```
Done!
==================
WARNING: ThreadSanitizer: data race
…
```
So apparently the TSan report output is not guaranteed to be printed
before "Done!". Maybe this is because we print "Done!" on stdout and
the sanitizer report on stderr?
The remaining question is: what changed that we are seeing this issue
now, but not previously?
rdar://99713724
(cherry picked from commit 35c7c41)
|
@swift-ci Please test |
|
cc: @aschwaighofer |
devincoughlin
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test does:
We see some recent cases where the output of the test binary on iOS devices was:
So apparently the TSan report output is not guaranteed to be printed before "Done!". Maybe this is because we print "Done!" on stdout and the sanitizer report on stderr?
The remaining question is: what changed that we are seeing this issue now, but not previously?
rdar://99713724
(cherry picked from commit 35c7c41)