Skip to content

New parser build cleanups #61178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2022

Conversation

DougGregor
Copy link
Member

Two cleanups to the build that includes the new parser:

  • [Unit tests] Use the rpaths determined for unit tests
  • [CMake] Disable the new Swift Swift parser if we can't find its targets file

The function that adds runtime link flags overrides RPATH settings via
`BUILD_WITH_INSTALL_RPATH`. Stop doing that for unit tests, because they
depend on host libraries built into `lib` not `lib/swift/${platformname}`.
…ts file

This allows us to more gracefully degrade when a host Swift toolchain
can't be found, and the early SwiftSyntax build is skipped as a result.
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor DougGregor merged commit 8743107 into swiftlang:main Sep 18, 2022
@DougGregor DougGregor deleted the new-parser-build-cleanups branch September 18, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant