[cxx-interop] Fix friend operators that come from class template specializations. #61181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoecarver
commented
Sep 19, 2022
|
|
||
| var StdMapTestSuite = TestSuite("std::map") | ||
|
|
||
| extension Map.const_iterator : UnsafeCxxInputIterator { } |
There was a problem hiding this comment.
|
This is kind of related to: rdar://100021897 as it'd mean we don't have to use |
zoecarver
force-pushed
the
lookup-operator
branch
from
a6960ff to
d7b7c5e
Compare
|
@swift-ci please test |
zoecarver
force-pushed
the
lookup-operator
branch
from
d7b7c5e to
855e64b
Compare
zoecarver
commented
Oct 10, 2022
Comment on lines
9
to
10
| import StdMap | ||
| import std.map |
There was a problem hiding this comment.
@egorzhdan am I supposed to just use StdMap. If so, that caused problems locally (looking up operator==, I think).
|
@swift-ci please smoke test |
zoecarver
force-pushed
the
lookup-operator
branch
from
855e64b to
0010337
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.