Skip to content

[NFC] Rename MissingImport cases and tests #61190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Sep 19, 2022

Rename internal references to missing imports to be more clear as to the source of the issue, and to avoid confusion as the previous name was already used for expected implicit imports.

The concept of implicit import was already in use so let's differentiate
better the case of a missing import.
@xymus
Copy link
Contributor Author

xymus commented Sep 19, 2022

@swift-ci Please smoke test

@xymus xymus requested a review from tshortli September 19, 2022 22:27
Copy link
Contributor

@tshortli tshortli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good clarification to me!

@xymus
Copy link
Contributor Author

xymus commented Sep 19, 2022

@swift-ci Please smoke test macOS

1 similar comment
@xymus
Copy link
Contributor Author

xymus commented Sep 20, 2022

@swift-ci Please smoke test macOS

@xymus xymus merged commit 009f65e into swiftlang:main Sep 20, 2022
@xymus xymus deleted the rename-missing-import branch September 20, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants