[interop][SwiftToCxx] trap on moves of Swift values for now #61224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move support will be added later
|
@swift-ci please test |
egorzhdan
reviewed
Sep 21, 2022
| printer.printBaseName(typeDecl); | ||
| os << "("; | ||
| printer.printBaseName(typeDecl); | ||
| os << " &&) = default;\n"; | ||
| os << " &&) { abort(); }\n"; |
There was a problem hiding this comment.
Could we emit = delete instead? That might be more helpful for the user since accidentally using the move constructor would be a compile error instead of a runtime error.
There was a problem hiding this comment.
I can't emit delete, as C++ will not compile the elided moves that are not actually runtime moves, that I need to return such type from the thunk wrapper .
There was a problem hiding this comment.
inline SwiftType thunk() {
auto result = SwiftType::make();
$swiftFunction(&result);
return result; // <-- this will not compile if the move constructor is deleted, but it's elided according to C++ rules so it does not trap.
}
There was a problem hiding this comment.
I see, makes sense, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move support will be added later once values are takeable.