Skip to content

[SymbolGraphGen] don't use null types when determining extension access level #61227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

QuietMisdreavus
Copy link
Contributor

Fixes rdar://100169094, fixes #61201

This PR fixes a crash in SourceKit when calculating nested expressions, by double-checking whether a type actually exists before finding its NominalTypeDecl.

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

Copy link
Contributor

@daniel-grumberg daniel-grumberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuietMisdreavus QuietMisdreavus merged commit 4413cee into main Sep 21, 2022
@QuietMisdreavus QuietMisdreavus deleted the QuietMisdreavus/cursorinfo-ext branch September 21, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assertion failed: (Ptr && "Cannot dereference a null Type!") in swift::symbolgraphgen::Symbol::getEffectiveAccessLevel
2 participants