IRGen: Pass the elementType of pointers through to operations #61232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
aschwaighofer
force-pushed
the
wip_opaque_ptr_2
branch
from
ede28d6 to
4be9c87
Compare
|
@swift-ci test |
aschwaighofer
force-pushed
the
wip_opaque_ptr_2
branch
from
4be9c87 to
c2f2634
Compare
|
@swift-ci test |
aschwaighofer
force-pushed
the
wip_opaque_ptr_2
branch
from
c2f2634 to
5109fde
Compare
|
@swift-ci test |
aschwaighofer
force-pushed
the
wip_opaque_ptr_2
branch
from
5109fde to
7aea3ec
Compare
|
@swift-ci test |
|
@swift-ci test source compat |
|
@swift-ci test linux |
|
@swift-ci test |
|
@swift-ci test source compat |
In preparation for moving to llvm's opaque pointer representation replace getPointerElementType and CreateCall/CreateLoad/Store uses that dependent on the address operand's pointer element type. This means an `Address` carries the element type and we use `FunctionPointer` in more places or read the function type off the `llvm::Function`.
This should be computed by SignatureExpansion in a more correct way. The code here seems suspiciously off in the case we have both a direct return result and one indirect return result.
aschwaighofer
force-pushed
the
wip_opaque_ptr_2
branch
from
2d1359f to
5a46517
Compare
aschwaighofer
changed the title
|
@swift-ci test |
|
@swift-ci test source compat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for moving to llvm's opaque pointer representation replace getPointerElementType and CreateCall/CreateLoad/Store uses that dependent on the address operand's pointer element type.
This means an
Addresscarries the element type and we useFunctionPointerin more places or read the function type off thellvm::Function.