Parse: Offer a fix-it when platform is specified with the wrong case in availability attributes and queries #61234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
Nice QOL improvement.
I don't know if it's worth it here but I believe this could also handle simple typos if we use the string distance services StringRef::edit_distance to compare the original platform name with all known platform names and return the closest one.
That's a good idea - I opened #61237 to track investigating that as a follow up. |
…in availability attributes and queries. Resolves rdar://100195680
tshortli
force-pushed
the
correct-platform-case-fixit
branch
from
17ca34c to
f1ecb4c
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Resolves rdar://100195680