Skip to content

[ConstraintSystem] Extend availability check to cover unavailable extensions #61243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

[ConstraintSystem] Extend availability check to cover unavailable extensions #61243

merged 1 commit into from
Sep 22, 2022

Conversation

tshortli
Copy link
Contributor

Instead of checking for unavailability attributes directly in the solver, use AvailableAttr::isUnavailable which checks the enclosing extension too, if necessary.

Resolves rdar://92364955

@tshortli
[ConstraintSystem] Extend availability check to cover unavailable ext…
6de6de2 
…ensions.

Instead of checking for unavailability attributes directly in the solver, use `AvailableAttr::isUnavailable` which checks the enclosing extension too, if necessary.

Resolves rdar://92364955
@tshortli
Copy link
Contributor Author

This re-introduces the changes from #58466 which were reverted originally because they exposed an issue in the availability checker. That issue was fixed in #58680.

@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli marked this pull request as ready for review September 22, 2022 16:19
@tshortli tshortli requested review from xedin and hborla September 22, 2022 16:20
xedin
xedin approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tshortli tshortli merged commit f7b1f71 into swiftlang:main Sep 22, 2022
@tshortli tshortli deleted the solver-ignore-decls-in-unavailable-extensions branch September 22, 2022 16:58
@tshortli tshortli mentioned this pull request Nov 2, 2022
Merged
swift-ci added a commit that referenced this pull request Nov 2, 2022
@swift-ci
Merge pull request #61859 from tshortli/rdar-101814209
753b906 
ConstraintSystem: Revert #61243
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

@hborla hborla Awaiting requested review from hborla hborla is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tshortli @xedin