[5.7][android] Update to LTS NDK 25b (#60938) #61297
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of 5.7-relevant portions of #60938 and single doc change from #61873
Explanation: Make it so that the Swift build detects the clang shipping in the Android NDK, rather than having to manually update
SWIFT_ANDROID_NDK_CLANG_VERSION
every time, by extracting the versioned resource directory from the NDK usingfile(GLOB)
.Scope: Only affects cross-compiling for Android with the NDK
SR Issue: None
Risk: Essentially none, since it only affects Android
Testing: This patch got trunk compiling on the community Android CI again with the latest NDK 25b.
Reviewer: @DougGregor
This pull will keep 5.7 patch releases compiling with future NDK releases, rather than having to manually patch this repo with the new clang version each time. Since this pull is so low-risk, I thought it is worth getting in to 5.7.