Work Around _swiftStaticArrayMetadata Alias Breakage #61322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alias defined here with the `.set` directive doesn't actually define a symbolic alias that the linker respects in all cases. The resulting standard library dylib _does_ contain a reference to the aliased symbol with the correct value, but the resulting variable is not actually considered relocatable by the linker. Thus, its value may not always get fixed up properly. Work around this by dropping the alias for now - directly use the type metadata for Swift.__EmptyArrayStorage instead. rdar://100288247
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alias defined here with the
.setdirective doesn't actually define a symbolic alias that the linker respects in all cases. The resulting standard library dylib does contain a reference to the aliased symbol with the correct value, but the resulting symbol is not actually considered relocatable by the linker. Thus, its value may not always get fixed up properly.Work around this by dropping the alias for now - directly use the type metadata for Swift.__EmptyArrayStorage instead.
rdar://100288247