[Demangler] Fix isThunkSymbol() to handle continuations. #61330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
TODO: I need to update the |
eeckstein
approved these changes
Sep 29, 2022
al45tair
force-pushed
the
eng/PR-100424460
branch
2 times, most recently
from
5d63dfe to
dd6d6e0
Compare
…uations. `isThunkSymbol()` was returning false for await resume and suspend resume thunks because the `Node` tree for those has an `AsyncAwaitResumePartialFunction` and/or `AsyncSuspendResumePartialFunction` as the first child of the top level `Global`, with the actual thunk in the _second_ child location. rdar://100424460
al45tair
force-pushed
the
eng/PR-100424460
branch
from
dd6d6e0 to
54ea4b2
Compare
|
@swift-ci Please smoke test |
|
Added some tests and fixed a bug they exposed, which also made the fix simpler :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isThunkSymbol()was returning false for await resume and suspend resume thunks because theNodetree for those has anAsyncAwaitResumePartialFunctionand/orAsyncSuspendResumePartialFunctionas the first child of the top levelGlobal, with the actual thunk in the second child location.rdar://100424460