[CopyPropagation] Removed poison mode. #61344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Onone strategy will be to shorten lifetimes as little as possible while eliminating as many copies as are eliminated at -O.
|
@swift-ci please test |
atrick
approved these changes
Sep 29, 2022
There was a problem hiding this comment.
I think you should go ahead and remove this mode since it will make refactoring the code easier.
I'm almost certain we have a new way of emitting DWARF to indicate when a variable's lifetime ends. So we should no longer need to write a poison marker into the shadow variable's stack slot. /cc @adrian-prantl
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-Ononestrategy will be to shorten lifetimes as little as possible while eliminating as many copies as are eliminated at-O.