Skip to content

[Docs] improve @_spiOnly attribute info #61399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

MarcoEidinger
Copy link
Contributor

Related to b680084

@LucianoPAlmeida LucianoPAlmeida requested a review from xymus October 1, 2022 02:29
Copy link
Contributor

@xymus xymus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

@MarcoEidinger
Copy link
Contributor Author

@xymus thanks for the approval.

@LucianoPAlmeida anything else I need to do before this can be merged? I am not sure why the test checks did not run. I guess because there are no coding changes :)

@xymus
Copy link
Contributor

xymus commented Oct 4, 2022

We're old school here, we need to request the tests manually.

@swift-ci Please smoke test

@LucianoPAlmeida
Copy link
Contributor

@swift-ci Please smoke test macOS platform

@LucianoPAlmeida
Copy link
Contributor

@swift-ci Please smoke test Linux platform

@LucianoPAlmeida LucianoPAlmeida merged commit be8e7db into swiftlang:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants